Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies to get python 3.9 support on s390x #395

Merged
merged 1 commit into from
Jul 5, 2020

Conversation

mayeut
Copy link
Member

@mayeut mayeut commented Jul 4, 2020

Update dependencies to get python 3.9 support on s390x
Only updating manylinux images would be enough but this also tests other updates.

@mayeut
Copy link
Member Author

mayeut commented Jul 4, 2020

This won't get built on travis-ci because only master branch gets built (this includes target branch for PR)

@YannickJadoul
Copy link
Member

Huh, why do we only build the master branch? Seems a leftover from @joerick trying to stop his own PRs building twice (because it being a PR and it being a commit): 9762867. But this seems unintended, no?

Apart from that, thanks for noticing that s390x is now working!

Any reason to update the other versions, if we're not making a release? I'd somehow say it would be nice to have these the same as the last true release, such that trying out Python 3.9 and our branch wouldn't get any unexpected consequences/errors?

@joerick
Copy link
Contributor

joerick commented Jul 4, 2020

Can you not see a Travis build? I see it - https://travis-ci.org/github/joerick/cibuildwheel/builds/704961809

@YannickJadoul
Copy link
Member

YannickJadoul commented Jul 4, 2020

I think it's triggered by #396, and Travis just confuses them because they are the same commit, no?

EDIT: This one, #395, doesn't show up here: https://travis-ci.org/github/joerick/cibuildwheel/pull_requests

@mayeut
Copy link
Member Author

mayeut commented Jul 5, 2020

I think it's triggered by #396, and Travis just confuses them because they are the same commit, no?

Yes exactly.

Any reason to update the other versions, if we're not making a release? I'd somehow say it would be nice to have these the same as the last true release, such that trying out Python 3.9 and our branch wouldn't get any unexpected consequences/errors?

I wanted to check for unexpected errors with other updates at first (and because running python bin/update_dependencies.py is easy and updates all). I now dropped the other updates and just update the docker images.

Edit: updating other dependencies had for effect what seems to be a deadlock on macOS on travis-ci...

@joerick
Copy link
Contributor

joerick commented Jul 5, 2020

Ah, I see - #396 is just to trigger CI. Looks like it's green, so feel free to merge into python3.9!

@YannickJadoul
Copy link
Member

Edit: updating other dependencies had for effect what seems to be a deadlock on macOS on travis-ci...

Huh, good to know, thanks! We shouldn't do this update too last minute before the next update, then, @joerick!

Meanwhile, let's get this updated. Thanks again! :-)

@YannickJadoul YannickJadoul merged commit 737ad6b into pypa:python3.9 Jul 5, 2020
@YannickJadoul YannickJadoul mentioned this pull request Jul 5, 2020
@mayeut mayeut deleted the python3.9-s390x branch July 5, 2020 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants